facebook / facebook-java-business-sdk

Java SDK for Meta Marketing APIs

https://developers.facebook.com/docs/business-sdk

Other

393 stars 324 forks source link

fix: `ExtendedDeviceInfo` attributes addition #427

Closed An1s9n closed 5 months ago

An1s9n commented 1 year ago

Dear team, I kindly ask you to accept my pull request. It brings following benefits:

while setting attributes you do not depend on attributes ordering anymore (before this fix if you would try to set attributes in arbitrary order you are likely to receive IndexOutOfBoundsException)
you can safely omit attributes you can not provide (facebook api asks to send empty string "" if you can not provide some attribute, but this SDK forces you to provide all attributes. Yes, you can pass "" manually, but it would be nice if it would be a default behavior managed by SDK)
make integer attributes safely nullable (in cases of String attributes you can pass manually "", but in case of int this is not possible. It would be nice if user of this SDK would pass just an Integer object not caring about possible nulls. Nulls will be translated to empty strings by SDK

facebook-github-bot commented 1 year ago

Hi @An1s9n!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

An1s9n commented 1 year ago

Anyone?

stcheng commented 1 year ago

@An1s9n thank you for the PR. I'll try to review it and get back to you.

An1s9n commented 11 months ago

@stcheng, just let me know if there is something I can fix: I would be more than happy to do so :)

An1s9n commented 6 months ago

Any news about this..? Want to complete all TODOs in my project :)

facebook-github-bot commented 5 months ago

@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 5 months ago

@stcheng merged this pull request in facebook/facebook-java-business-sdk@3a5d34880f2f2d3f2958948565a8dec0b7ba7d7f.

An1s9n commented 5 months ago

@stcheng, thank you!)