search

facebook / facebook-java-business-sdk

Java SDK for Meta Marketing APIs
https://developers.facebook.com/docs/business-sdk
Other
393 stars 324 forks source link

Fix adding 3 parameter into addCallback call #444

Open kzamora opened 8 months ago

kzamora commented 8 months ago

Added parameter executor to Futures.addCallback call:

MoreExecutors.directExecutor()

facebook-github-bot commented 8 months ago

Hi @kzamora!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

stcheng commented 8 months ago

@kzamora could you help sign the CLA?

facebook-github-bot commented 8 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

stcheng commented 7 months ago

hi @kzamora i noticed that you only add this parameter in one function call in the AdAccount.java file. Could you elaborate more about the use case here and about the goal you want to achieve?