search

facebook / facebook-java-business-sdk

Java SDK for Meta Marketing APIs
https://developers.facebook.com/docs/business-sdk
Other
393 stars 324 forks source link

Added optional proxy parameter in APIContext class to accommodate opt… #459

Open saisrinivaslakkakula opened 2 months ago

saisrinivaslakkakula commented 2 months ago

…ional proxy parameter for enterprises that may require as such

facebook-github-bot commented 2 months ago

Hi @saisrinivaslakkakula!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

stcheng commented 1 month ago

@saisrinivaslakkakula thanks for contributing to the project. I have reviewed the pull request and it appears that this patch is a use case that is closely aligned with your production scenario. To better maintain our SDKs in five languages, we want to limit the divergence of specific languages from others and the features that cannot be actively maintained by Meta. Thus, I would suggest keeping this diff as patches to the current SDK and maintaining it separately. In this way, it would be much easier to maintain the business SDK while ensuring that your workflow operates smoothly.