Closed yoongyj closed 1 year ago
Should we allow false
in the normalize
method as the parameter 'advertiser_tracking_enabled' is required for the event with the action source 'app'
Existing
if (this.advertiser_tracking_enabled) {
serverEvent.advertiser_tracking_enabled = this.advertiser_tracking_enabled;
}
proposed:
if (this.advertiser_tracking_enabled === true || this.advertiser_tracking_enabled === false) {
serverEvent.advertiser_tracking_enabled = this.advertiser_tracking_enabled;
}
Similar to https://github.com/facebook/facebook-nodejs-business-sdk/pull/214
@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
@yoongyj thank you for creating this diff to address this bug @jcurlier this seems a legit change, i'll create a diff to address this as well as to merge the #214 thank you
@stcheng merged this pull request in facebook/facebook-nodejs-business-sdk@e59913f5862f5c1cd065050c2177e7c1d75de6eb.
thanks @stcheng for merging this pull request!
Currently
advertiser_tracking_enabled()
is returning_data_processing_options_country
, it should be returning_advertiser_tracking_enabled
instead.