search

facebook / facebook-nodejs-business-sdk

Node.js SDK for Meta Marketing APIs
https://developers.facebook.com/docs/business-sdk
Other
489 stars 226 forks source link

Replace Deprecated npm Package request with axios #257

Closed genlyken closed 1 year ago

genlyken commented 1 year ago

Replace Deprecated npm Package 'request' Using axios.

genlyken commented 1 year ago

Tested by creating Campaign, Adset and Ads.

useMultipartFormData doesn't seem to be used so I couldn't test it.

Screenshot 2023-08-07 at 5 29 05 PM
facebook-github-bot commented 1 year ago

Hi @genlyken!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

stcheng commented 1 year ago

@genlyken thank you so much for submitting this PR. To complete CLA check, please go to here: https://code.facebook.com/cla and finish the steps. I will meanwhile try to evaluate if this PR works as expected with some tests. Appreciate your contribution.

stcheng commented 1 year ago

closing this with the commit a2d64d93485f353ad6a3e78709c7d7fc858dcbc2