facebook / facebook-php-business-sdk

PHP SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
833 stars 516 forks source link

Add const for file_url in AdVideoFields #494

Closed mmccaff closed 5 years ago

mmccaff commented 5 years ago

Add const for FILE_URL to AdVideoFields so that a new AdVideo can be created from a URL, following the same style used in the example in the documentation.

For more details, see my comment in this issue https://github.com/facebook/facebook-php-business-sdk/issues/465

facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 5 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

jingping2015 commented 5 years ago

This should be solved in our next release