search

facebook / facebook-php-business-sdk

PHP SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
817 stars 514 forks source link

Define the http_build_query arg separator. #498

Closed cerber717 closed 5 years ago

cerber717 commented 5 years ago

In our code we use custom arg_separator which surfaced a need of defining to assure a proper function of the SDK.

facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 5 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

cerber717 commented 5 years ago

HHVM failors seems to unrelated.

cerber717 commented 5 years ago

@jingping2015 could you please look at this ?

kkopachev commented 5 years ago

Any progress here?

jingping2015 commented 5 years ago

@kkopachev Hi, this should be available for next release.

kkopachev commented 5 years ago

For the people tracking this issue: it has being merged in https://github.com/facebook/facebook-php-business-sdk/commit/7a8bd28eead86a94028287a13dac83c91646eee8 and released in 3.2.7 This PR could be closed.

cerber717 commented 5 years ago

@jingping2015 could you provide some info why this was not merged but rather copy and pasted ?