search

facebook / facebook-php-business-sdk

PHP SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
837 stars 519 forks source link

Correct Class Namespace to avoid Composer 2.0 autoloading issue #530

Closed andreladocruz closed 4 years ago

andreladocruz commented 4 years ago

Bump on this, it's been over 4 years for what is a tiny change. Composer 2.0 will stop autoloading this file, as per their optimised autoloader message:

Deprecation Notice: Class FacebookAds\Object\Agency located in ./vendor/facebook/php-ads-sdk/src/FacebookAds/Object/Fields/Agency.php does not comply with psr-4 autoloading standard. It will not autoload anymore in Composer v2.0. in phar:///usr/local/bin/composer/src/Composer/Autoload/ClassMapGenerator.php:201

Please can we have an update and/or fix, i.e. merge this PR, or rename the current file to be PSR-4 compatible, considering you support PSR-4.

formikaio commented 4 years ago

+1

unikapps commented 4 years ago

+1

andreladocruz commented 4 years ago

@jingping2015 , can you merge this, please?

simple namespace correction. =)

facebook-github-bot commented 4 years ago

@jingping2015 merged this pull request in facebook/facebook-php-business-sdk@724fc72953947787fd04efa1e26d33ab259e15f2.