search

facebook / facebook-php-business-sdk

PHP SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
817 stars 514 forks source link

Update AbstractCrudObject.php to fix for PHP8 #534

Closed sietzekeuning closed 3 years ago

sietzekeuning commented 3 years ago

In PHP8.0 it is not allowed to have required parameters after optional parameters, so I've made the $prototype_class optional

facebook-github-bot commented 3 years ago

Hi @sietzekeuning!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

b1rdex commented 3 years ago

Fixed in #535

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!