search

facebook / facebook-php-business-sdk

PHP SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
816 stars 513 forks source link

Fix namespacing in Doc Blocks #551

Open garhbod opened 2 years ago

facebook-github-bot commented 2 years ago

Hi @garhbod!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

jeremyfrench commented 1 year ago

This was signed over a year ago. I either have to use this to patch the download or put a bunch of exceptions in my code for it to not give me stan errors. It seems a trivial thing to merge.

garhbod commented 1 year ago

Yeah I thought it would have been accepted straight away as it doesn't really change the code. Just fixes the issue

mohlerit commented 8 months ago

I have the same issue. Namespace are wrong and phpstan show it as error. Can someone finally merge it, please? :-)

Thank you ;-)