facebook / facebook-php-business-sdk

PHP SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
838 stars 518 forks source link

Resolve PHP 8.1 Deprecations #554

Closed natewiebe13 closed 2 years ago

natewiebe13 commented 2 years ago

This resolves php 8.1 deprecations in a backwards compatible way.

More ideally, return types should be added to function definitions, but this would no longer support PHP 5.6 as described in the README. If the team is open to bumping up version requirements to only include supported PHP versions (7.4+), I can revisit this to add return types instead.

NelinD commented 2 years ago

need merge

stcheng commented 2 years ago

Thanks for your contribution. We'll evaluate if we would like to bump the version requirements, but the PR looks good.

facebook-github-bot commented 2 years ago

@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

stcheng commented 2 years ago

@natewiebe13 for this repository, it is only the generated files from the original source stored here. If you want to update the files, you shall submit the PR in the facebook-business-sdk-codegen repository. Thanks.

NelinD commented 2 years ago

@natewiebe13 Will you make it?

natewiebe13 commented 2 years ago

@stcheng I only see 2 of the 11 files in the code gen repo:

Are the other files somewhere else? Or how should I proceed with the changes?

natewiebe13 commented 2 years ago

I have also started a PR for those files here: https://github.com/facebook/facebook-business-sdk-codegen/pull/40

stcheng commented 2 years ago

@natewiebe13 thanks i'll check it out.

natewiebe13 commented 2 years ago

@stcheng any updates on this?

ujwaldhakal commented 2 years ago

waiting for this PR https://github.com/facebook/facebook-business-sdk-codegen/pull/40 to get merged