search

facebook / facebook-php-business-sdk

PHP SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
816 stars 513 forks source link

Fix syntax error #563

Closed natewiebe13 closed 1 year ago

natewiebe13 commented 1 year ago

The v15 tag has a syntax error, making the release unusable. This fixes the error.

@stcheng as mentioned in a previous PR, src/FacebookAds/Object/ServerSide does not appear in https://github.com/facebook/facebook-business-sdk-codegen/tree/main/templates/php/src/FacebookAds/Object. So if there is another place we should be updating this, please let me know.

facebook-github-bot commented 1 year ago

@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

natewiebe13 commented 1 year ago

As an aside, https://github.com/facebook/facebook-php-business-sdk/commit/049dfd15e5fd0ec994d6991a9d211019ad61b239 broke compatibility with PHP < 8.0. It's probably worth removing tests for php < 8.0 or reverting that commit. PHP 8.1 should also be added to the test matrix.

natewiebe13 commented 1 year ago

@stcheng thoughts on my comment above? Also can you tag a new release when possible?