facebook-github-bot
commented
1 year ago Hi @spiritinlife!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
stcheng
application_tracking_enabled and advertiser_tracking_enabled are required by the api as seen here https://developers.facebook.com/docs/marketing-api/conversions-api/parameters/app-data/.
Due to their nature (boolean) they can be false. The array_filter was removing them when they were falsy which was causing errors on the api request because they were missing.
This pr fixes this issue by moving the required attributes bellow the array_filter.