search

facebook / facebook-php-business-sdk

PHP SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
837 stars 519 forks source link

Incorrect PHPDoc types #605

Closed stefanfisk closed 3 months ago

stefanfisk commented 5 months ago

This causes PHPStan to generate errors like "Parameter #1 $user_data of method FacebookAds\Object\ServerSide\Event::setUserData() expects FacebookAds\Object\ServerSide\FacebookAds\Object\ServerSide\UserData, FacebookAds\Object\ServerSide\UserData given.PHPStan".

According to https://github.com/facebook/facebook-php-business-sdk/issues/new I should raise this issue at https://developers.facebook.com/support/bugs/. According to https://developers.facebook.com/support/bugs/ I should raise the issue in the Developer Community Forum. The form to post a new question just errors out with the message error performing query.

This does very much feel like screaming into the void...

stefanfisk commented 5 months ago

Just realized that someone opened #551 for this over two years ago...

stefanfisk commented 5 months ago

And that #545 was opened three years ago...

geoffreyrose commented 3 months ago

fixed in #606

stcheng commented 3 months ago

thanks @geoffreyrose !