search

facebook / facebook-python-business-sdk

Python SDK for Meta Marketing APIs
https://developers.facebook.com/docs/business-sdk
Other
1.29k stars 635 forks source link

Broken import in specs.py #476

Closed hdelva closed 6 years ago

hdelva commented 6 years ago

It seems like the changes in commit 68c08803aec25a089b9346bf2d33ba5c34fb3df7 didn't make it to the PyPI package. Trying to import anything from spec.py results in the following import error:

  File ".../python2.7/site-packages/facebook_business/specs.py", line 35, in <module>
    from facebook_business.adobjects import adcreativeofferdata
ImportError: cannot import name adcreativeofferdata

There is a simple workaround though, specs.py just defines aliases so it's possible to just import the original classes directly. Still, might want to update the PyPI package in case there's anyone else who likes using pretty aliases.

brandonkane commented 6 years ago

The commits were after the 3.0.0 tag. Would be great if FB could cut a 3.0.1 release with the commits that have been added since the 3.0.0 tag was created and pushed to pypi.

https://github.com/facebook/facebook-python-business-sdk/compare/3.0.0...master

jingping2015 commented 6 years ago

We've been unable to reproduce this bug, and are unable to investigate further. We are closing the issue for now, if you identify a test case we can use to reproduce your bug feel free to re-open.