search

facebook / facebook-python-business-sdk

Python SDK for Meta Marketing APIs
https://developers.facebook.com/docs/business-sdk
Other
1.29k stars 635 forks source link

url_override not really overriding #490

Closed howardic closed 6 years ago

howardic commented 6 years ago

https://github.com/facebook/facebook-python-business-sdk/blob/e2f279a62b7e6c7fd30a080b4be8103c7303a715/facebook_business/api.py#L285

It really feels like this line should read:

 url_override or self._session.GRAPH,

since GRAPH is a string constant and never False

jingping2015 commented 6 years ago

This issue already fixed https://github.com/facebook/facebook-python-business-sdk/blob/ccef9154d2c201ef71ea5ac94326b9f10b122e56/facebook_business/api.py#L285