python3.7 "async" keyword fixes & Travis CI config improvements

facebook / facebook-python-business-sdk

Python SDK for Meta Marketing APIs

https://developers.facebook.com/docs/business-sdk

Other

1.29k stars 635 forks source link

python3.7 "async" keyword fixes & Travis CI config improvements #491

Closed alternativshik closed 5 years ago

alternativshik commented 6 years ago

Keyword arg async was renamed to is_async for python 3.7 support

facebook-github-bot commented 6 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 6 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

avborhanian commented 6 years ago

Looks like they just updated their generated code to use is_async instead!

alternativshik commented 6 years ago

@avborhanian Don't see any async changes in latest Auto generated code(17 hours ago)...

avborhanian commented 6 years ago

https://github.com/facebook/facebook-python-business-sdk/blob/ccef9154d2c201ef71ea5ac94326b9f10b122e56/facebook_business/adobjects/page.py#L1263

Looks like it was done in the one last time, just not pushed to PyPi till recently.

alternativshik commented 6 years ago

@avborhanian LOL, they fix it only in ONE place? There are many files with async keyword still with "async"

https://github.com/facebook/facebook-python-business-sdk/blob/master/facebook_business/adobjects/abstractcrudobject.py#L552

avborhanian commented 6 years ago

LMAO you're right, it's only a few. I got hit by this because I updated the lib this morning, apparently only 8 places. Still some progress to make.

leahein commented 6 years ago

Bumping this -- this is still an issue in version 3.1.2, specifically in:

facebook_business/adobjects/helpers/businessmixin.py
facebook_business/adobjects/abstractcrudobject.py

revmischa commented 6 years ago

This issue is preventing use of the latest stable python release 3.7.0. Please put this on pypi.

alternativshik commented 6 years ago

@revmischa Just install it from github and use.

revmischa commented 6 years ago

@alternativshik I installed it from your github and then all of my requests strangely started using v3.0 instead of v3.1. Any idea why?

    "message": "(#2635) You are calling a deprecated version of the Ads API. Please update to the latest version: v3.1.",

I don't get it when using the PyPI version

alternativshik commented 6 years ago

Install It from facebook master brunch not from my github...

revmischa commented 6 years ago

It's not merged to FB master branch is it? https://github.com/facebook/facebook-python-business-sdk/commits/master

arorasudhir commented 6 years ago

Any update on this? I am still facing the issue in https://github.com/facebook/facebook-python-business-sdk/blob/master/facebook_business/adobjects/abstractcrudobject.py#L552

revmischa commented 6 years ago

This is preventing upgrading to 3.7

hecvd commented 6 years ago

Any update on this? this is breaking our development.

codytwinton commented 5 years ago

This has been resolved in master