search

facebook / facebook-python-business-sdk

Python SDK for Meta Marketing APIs
https://developers.facebook.com/docs/business-sdk
Other
1.28k stars 631 forks source link

Fixed NameError in AbstractObject.__eq__ #524

Closed kavdev closed 5 years ago

kavdev commented 5 years ago

Fixes same issue as in https://github.com/facebook/facebook-python-business-sdk/pull/520, but only changes affected code.

Note that tests are failing because python 3.3 isn't in your Travis environment. (the other PR removes the 3.3 tox envs in addition to this fix)

facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

kavdev commented 5 years ago

Was broken in https://github.com/facebook/facebook-python-business-sdk/commit/dd8d9de4519f98feb5bfc3e9271d18be8110c6a6

facebook-github-bot commented 5 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

jingping2015 commented 5 years ago

This issue has been fixed. Thanks for reporting this issue.

kavdev commented 5 years ago

@jingping2015 can you point me to the commit in which it's fixed?

jingping2015 commented 5 years ago

https://github.com/facebook/facebook-python-business-sdk/commit/e61180c4feac4189fa2df86b21c48b6c6ae73a87#diff-5c2ee73c9f7f6f616946f19e23a7dae9