facebook / facebook-python-business-sdk

Python SDK for Meta Marketing APIs
https://developers.facebook.com/docs/business-sdk
Other
1.28k stars 631 forks source link

Added per-Cursor headers support. #538

Closed vitos555 closed 5 years ago

vitos555 commented 5 years ago

Main intent for this PR is to give visibility into per-request headers. With this change API users can monitor X-FB-Ads-Insights-Throttle and X-Ad-Account-Usage headers themselves and introduce sleeps in their code if needed.

facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 5 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

vitalious commented 5 years ago

Finally found this gem. Can this please be merged?

dpatz commented 5 years ago

@jingping2015 Would you mind merging this?

dpatz commented 5 years ago

@jingping2015 Thanks!

facebook-github-bot commented 5 years ago

@jingping2015 merged this pull request in facebook/facebook-python-business-sdk@7ae0ae4e32ebd51ed56ad9fcd4c7c2a22201554c.

jingping2015 commented 5 years ago

It should available for next release.