search

facebook / facebook-python-business-sdk

Python SDK for Meta Marketing APIs
https://developers.facebook.com/docs/business-sdk
Other
1.27k stars 629 forks source link

Do not install test requirements in distribution #578

Closed joekohlsdorf closed 3 years ago

joekohlsdorf commented 3 years ago

Installing facebook-python-business-sdk from PyPI installs mock, a development requirement. This PR only installs development requirements when running tests.

facebook-github-bot commented 3 years ago

Hi @joekohlsdorf!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

joekohlsdorf commented 3 years ago

Looks like tests fail but I can't see the output, can you give me a hint what the problem could be? I ran the tests locally with the commands you have in the Travis config in a virgin Docker container before submitting the PR and had no issues.

facebook-github-bot commented 3 years ago

This pull request has been merged in facebook/facebook-python-business-sdk@6b5ca676db0846e07b870a868dfd1e5fedab4085.