search

facebook / facebook-python-business-sdk

Python SDK for Meta Marketing APIs
https://developers.facebook.com/docs/business-sdk
Other
1.27k stars 629 forks source link

Fix is_success() check for non-json response which body contains 'success' somehow. #579

Closed madbird1304 closed 2 years ago

madbird1304 commented 3 years ago

I was receiving payload like below frequently with 502 responses. It leads to inconsistent response handling in further SDK code and finally ends up with TypeError: string indices must be integers sooner or later. 20201026_17h32m19s_grim 20201026_17h33m10s_grim

facebook-github-bot commented 3 years ago

Hi @madbirddiary!

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file.

In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

jingping2015 commented 3 years ago

Hi, thanks for submit this PR, can you sign our Contributor License Agreement.

facebook-github-bot commented 3 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

madbird1304 commented 3 years ago

Hi, @jingping2015 , may I ask you to restart the CI pipeline?

madbird1304 commented 3 years ago

Is there anybody in there?

madbird1304 commented 2 years ago

Tired of seeing it in open PRs