facebook-github-bot
commented
3 years ago Hi @tiwariayush!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!
Currently, in the normalise process, we do hash even the already hashed values. This makes it impossible to do testing from local servers. There are a lot of bugs being reported on support because of this.
The only way to be able to test it to use the hashed email provided by Payload Helper. But the current flow of normalisation rehashes the hashed value.
This PR will test if the value is already hashed and will not try to re-hash it.