facebook / facebook-python-business-sdk

Python SDK for Meta Marketing APIs
https://developers.facebook.com/docs/business-sdk
Other
1.3k stars 640 forks source link

update api and sdk version to v13 #609

Closed marcosmarxm closed 2 years ago

facebook-github-bot commented 2 years ago

Hi @marcosmarxm!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

harshithmullapudi commented 2 years ago

@marcosmarxm can you sign the CLA here?

marcosmarxm commented 2 years ago

@marcosmarxm can you sign the CLA here?

done

facebook-github-bot commented 2 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

marcosmarxm commented 2 years ago

@thiagocmoraes would you help me here? There is any workflow I need to follow to get a review?

oseh-stake commented 2 years ago

Thank you @marcosmarxm 🙌 - have been encountering this issue as well

bxjw commented 2 years ago

would also like this merged. Trying to understand why Facebook's own official SDK wouldn't update along with their API versions

collinmpage commented 2 years ago

Has this issue been resolved yet?

jurrigerretsen commented 2 years ago

Would also like to see this merged it is blocking me right now

oseh-stake commented 2 years ago

would also like this merged. Trying to understand why Facebook's own official SDK wouldn't update along with their API versions

Beggars belief

kfallows-adl commented 2 years ago

Please merge this!!

beubeu13220 commented 2 years ago

We are also waiting this merge 👍

Luttik commented 2 years ago

Hé this merge is very important to us since the facebook API has now started throwing error codes if you use v12:

Example

Status:  400
  Response:
    {
      "error": {
        "message": "(#2635) You are calling a deprecated version of the Ads API. Please update to the latest version: v13.0.",
        "type": "OAuthException",
        "code": 2635,
        "fbtrace_id": "AAOEMw96o0wSs67yOb0pYQy"
      }
    }
LorienMan commented 2 years ago

I wonder how the API version was deprecated without an official library release 😬 Please merge!

laskoviymishka commented 2 years ago

I wonder how that happened - https://developers.facebook.com/blog/post/2022/02/08/introducing-facebook-graph-marketing-api-v13/ Per official release - Marketing API v12.0 will deprecate on 08/09/2022, but its deprecated couple weeks ago. I believe someone should merge this ASAP or rollback API deprecation

osehmathias commented 2 years ago

This is truly unbelievable

I reached out to Facebook

The response was, "This is a community-maintained package and is not maintained by Facebook. As a result, we can not offer support in this instance."

I asked, "Who can I contact about merging this PR?"

The response, "We can not offer support for community-maintained packages."

bxjw commented 2 years ago

Okay wait so…who has the ability to approve the workflow then…

Just1B commented 2 years ago

Community-maintained package ? it's very confusing because in the contributing file below, they say that it's an internal tool exposed publicly by team members after reviews.

https://github.com/facebook/facebook-python-business-sdk/blob/main/CONTRIBUTING.md

Our Development Process The Facebook Ads API SDK for Python is currently developed in Facebook's internal repositories and then exported out to GitHub by a Facebook team member. We invite you to submit pull requests directly to GitHub and, after review, these can be merged into the project.

How it is possible for us to know the shape of adobjects exposed by the api if there are no interventions from the API team ...

pjatx commented 2 years ago

Please merge!

DeTeam commented 2 years ago

Seems like there are no breaking changes expected 12 -> 13 for business SDK (right?). @jingping2015 @donglinw-fb could you have a look and maybe support with releasing new version of this SDK? 🙏

DeTeam commented 2 years ago

@marcosmarxm https://github.com/facebook/facebook-python-business-sdk/blob/main/facebook_business/apiconfig.py#L22-L23 — seems like it's already 13 (was autogenerated recently in https://github.com/facebook/facebook-python-business-sdk/commit/5cfd5cc9cc6730c9bba16a679464d839106010e0 with some involvement from @jawwad).

https://pypi.org/project/facebook-business/#history — seems like the version wasn't updated in pypi, @jawwad, could you maybe have a look? 😊

Looks like creating & pushing a tag would be enough https://github.com/facebook/facebook-python-business-sdk/actions/workflows/ci-publish.yml

marcosmarxm commented 2 years ago

The SDK was updated to 13.0.0 version.

WillLiuMH commented 2 years ago

Looks like the API is requiring version 14 now but the SDK is still on version 13.

"message": "(#2635) You are calling a deprecated version of the Ads API. Please update to the latest version: v14.0.",

Can someone please update this?