Closed mst closed 1 year ago
Hi @mst!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Hello @mst. I'm experiencing the same issue. I found your solution correct however those files are auto generated in this project. I'll try to create pull request in this project: https://github.com/facebook/facebook-business-sdk-codegen
Edit: I created bug in codegen project: https://github.com/facebook/facebook-business-sdk-codegen/issues/47
thanks for the pull request, we're aware of this issue. we'll try to address this asap.
targeting_optimization_types
comes from the API as alist<map<string,int>>
, notmap<string,int>
There are other objects that use
targeting_optimization_types
, I haven't tested these yet:facebook_business/adobjects/adaccountdeliveryestimate.py facebook_business/adobjects/adcampaigndeliveryestimate.py
Please advise if they need to be changed too.