facebook / facebook-python-business-sdk

Python SDK for Meta Marketing APIs
https://developers.facebook.com/docs/business-sdk
Other
1.32k stars 645 forks source link

Update ad.py #644

Closed concaption closed 1 year ago

concaption commented 1 year ago

As shown on this link we need to add ad_active time.

facebook-github-bot commented 1 year ago

Hi @concaption!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

concaption commented 1 year ago

Also, filtering on ad_active_time is not supported. How can we get those ads that became active during any period? or how can we get ads that were active during that period.

{'error': {'message': "(#100) Filtering field 'ad_active_time' is not supported", 'type': 'OAuthException', 'code': 100, 'error_data': 'An unknown error occurred', 'fbtrace_id': 'APvto-85kj-YDa9tyPREtbF'}}

concaption commented 1 year ago

I think ad_active_time is 0 for all my ads. Also the filter on update_time is not working.

stcheng commented 1 year ago

Hello @concaption after checking internally, we have confirmed that this field is an internal only field and shall not be exposed. We will remove this field from the documentation as well as in the SDK later. Sorry for the confusion.