facebook / facebook-python-business-sdk

Python SDK for Meta Marketing APIs
https://developers.facebook.com/docs/business-sdk
Other
1.27k stars 629 forks source link

Update readme: changed `AdUser` class to `User` #653

Closed IvanRamyk closed 9 months ago

IvanRamyk commented 9 months ago

changed AdUser class to User that is actually present in the SDK and added the correct import line to the example

facebook-github-bot commented 9 months ago

Hi @IvanRamyk!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

IvanRamyk commented 9 months ago

Also, there are other places where AdUser is mentioned but I fixed only description that is related to my use case where I'm sure that it works

stcheng commented 9 months ago

@IvanRamyk thank you. Could you sign the CLA? We could then import this change!

IvanRamyk commented 9 months ago

@stcheng done :)

facebook-github-bot commented 9 months ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 9 months ago

@stcheng has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 9 months ago

@stcheng merged this pull request in facebook/facebook-python-business-sdk@59b514b270ab3b4fbea8d2229651e303252d3710.