facebook-github-bot
commented
7 months ago Hi @joshuamc98!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Fixed issue with not parsing <list<map correctly.
I first noticed this when getting products underneath a product catalog. One of the items in the request consisted of a <list<list<map<string, string>>> value_type. This is currently not handled when this is parsed in the existing code. In the existing code, sub_type_value tries to access an index of the subtypes list that does not exist. I noticed some similar code in the function get_typed_value which I've used in the fix.