search

facebook / facebook-ruby-business-sdk

Ruby SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
209 stars 160 forks source link

Support Ruby 3.0.0 #127

Closed IanVaughan closed 3 years ago

IanVaughan commented 3 years ago

Which SDK version are you using?

0.9.0.2

What's the issue?

Cannot bundle install the gem on ruby 3.0.0

Steps/Sample code to reproduce the issue

Gemfile :

source 'https://rubygems.org'
ruby '3.0.0'
gem 'facebookbusiness'
> bundle install

Bundler found conflicting requirements for the Ruby version:
  In Gemfile:
    Ruby (~> 3.0.0.0)

    facebookbusiness (~> 0.9.0.2) was resolved to 0.9.0.2, which depends on
      Ruby (~> 2.0)

Expected Results:

It should install ok

matthieua commented 3 years ago

Could someone please look into this? We can't upgrade to Ruby 3 because of this.

wilsonsilva commented 3 years ago

Hey @IanVaughan! I was about to suggest the same :D

matthieua commented 3 years ago

Here's a potential solution https://github.com/facebook/facebook-ruby-business-sdk/pull/129

Can someone at Facebook please look into this?

IanVaughan commented 3 years ago

Fixed via https://github.com/facebook/facebook-ruby-business-sdk/pull/129

matthieua commented 3 years ago

Thanks a lot @IanVaughan ! Just upgraded to Ruby 3.0!