Allow countries versions 3.X or 4.X

[niels]

There don't seem to be any breaking changes in v4.

[facebook-github-bot]

Hi @niels!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[matthieua]

Any updates on this, please? This is block a lot of dependencies from upgrading

[facebook-github-bot]

@joesus has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[henrik]

Any updates, please?

This gem is currently the one thing preventing us from updating countries to 5 (so the next major after what this PR allows) – that one does have some breaking changes. It would be more motivating to look into those if this was merged first. EDIT: I did look… seems like https://github.com/facebook/facebook-ruby-business-sdk/blob/f2e6f54084ee50c16acbb31410acd60aa5c44fda/lib/facebook_ads/ad_objects/server_side/util.rb#L137 is the only place countries is used, and that method still seems supported. So should be fine.

[niels]

Technically, facebookbusiness still supports Ruby 2.5 & 2.6.

So with countries v5.0.0. dropping support for those Ruby versions, it would be incompatible with facebookbusiness.

(It would, of course, still be great to at least get this PR merged so that countries v4 gets allowed.)

[henrik]

@niels Good point. I've now made a PR for supporting countries 5 and thus requiring Ruby 2.7. We can then use that fork in our app until/if Facebook want to merge.

[alanho]

hi, this issue is fixed in the 56588d4e4d02d1b1e9856a8de41b1670ca1ec8ed commit. so closing it for now