search

facebook / facebook-ruby-business-sdk

Ruby SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
204 stars 161 forks source link

Gemspec: Allow countries 5 #179

Closed henrik closed 1 year ago

henrik commented 1 year ago

This lib only appears to use ISO3166::Country.search which still works in a compatible way in version 5.

https://github.com/facebook/facebook-ruby-business-sdk/blob/f2e6f54084ee50c16acbb31410acd60aa5c44fda/lib/facebook_ads/ad_objects/server_side/util.rb#L137

Removed from add_development_dependency because I don't see it being used in dev, and AFAIK if it's in the regular dependencies, we don't need to repeat it in the development dependencies anyway.

henrik commented 1 year ago

Will make a new and improved PR from our company org instead.