Closed Zajn closed 1 year ago
Hi @Zajn!
Thank you for your pull request and welcome to our community.
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed
. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
@alanho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.
thanks for the PR, this issue is addressed in 07f76898ddee14b6407774093e6121a340629ba1 so closing this for now
Description
This updates the dependency on Faraday from v1 to the latest v2.6.0. The following additional updates were made to support this:
bundle install
updated several of the dependencies in Gemfile.lockfaraday-multipart
was added since most bundled middlewares were moved out of the Faraday gem into their own gems.rspec
file which requiresspec_helper.rb
automatically was added so that the specs will actually run whenbundle exec rspec spec
is run