search

facebook / facebook-ruby-business-sdk

Ruby SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
204 stars 161 forks source link

Specs are not passing #194

Open dipth opened 1 year ago

dipth commented 1 year ago

Which SDK version are you using?

main

What's the issue?

Specs are failing with:

➜  facebook-ruby-business-sdk git:(main) ✗ bundle exec rspec
Calling `DidYouMean::SPELL_CHECKERS.merge!(error_name => spell_checker)' has been deprecated. Please call `DidYouMean.correct_error(error_name, spell_checker)' instead.

An error occurred while loading ./spec/ad_object_spec.rb.
Failure/Error:
  RSpec.describe FacebookAds::AdObject do
  end

NameError:
  uninitialized constant FacebookAds::AdObject

  RSpec.describe FacebookAds::AdObject do
                            ^^^^^^^^^^
# ./spec/ad_object_spec.rb:19:in `<top (required)>'

Finished in 0.00004 seconds (files took 0.20585 seconds to load)
0 examples, 0 failures, 1 error occurred outside of examples

Furthermore looking at .github/workflows/ci.yml it doesn't even appear that specs are run as part of the CI-build.

When was the last time someone actually ran these specs?

Steps/Sample code to reproduce the issue

git clone https://github.com/facebook/facebook-ruby-business-sdk.git
cd facebook-ruby-business-sdk
bundle install
bundle exec rspec

Observed Results:

Specs fail with the following error:

An error occurred while loading ./spec/ad_object_spec.rb.
Failure/Error:
  RSpec.describe FacebookAds::AdObject do
  end

NameError:
  uninitialized constant FacebookAds::AdObject

  RSpec.describe FacebookAds::AdObject do
                            ^^^^^^^^^^
# ./spec/ad_object_spec.rb:19:in `<top (required)>'

Expected Results:

Specs should have passed successfully.