facebook / facebook-ruby-business-sdk

Ruby SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
204 stars 161 forks source link

fix: CustomAudienceHelpers is broken for separation of positional and keyword arguments in Ruby 3.0 #200

Closed osdakira closed 11 months ago

osdakira commented 11 months ago

CustomAudienceHelpers is broken due to ruby3.0 spec changes. This should be fixed since the minimum supported version is ruby3.0.

https://www.ruby-lang.org/en/news/2019/12/12/separation-of-positional-and-keyword-arguments-in-ruby-3-0/

osdakira commented 11 months ago

@stcheng

Excuse my sudden mention, Sir. CustomAudienceHelper is broken since ruby3.0. Issues has been opened, but no one seems to have noticed it.

I wanted to mentions it, but I didn't know who to mentions it to, so I asked you, the latest reviewer. Can you please tell me who I can talk to about this?

[Issues]

facebook-github-bot commented 11 months ago

@alanho has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

alanho commented 11 months ago

@osdakira thanks for the report. we're working on merging this into main branch

osdakira commented 11 months ago

@alanho thank you for your quick response. I appreciate your working.

facebook-github-bot commented 11 months ago

@alanho merged this pull request in facebook/facebook-ruby-business-sdk@7bba445923e1d58ea1ed814436b1d25325f6764a.