search

facebook / facebook-ruby-business-sdk

Ruby SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
208 stars 160 forks source link

Invalid field type (map<string, unsigned int>) #21

Closed minsikzzang closed 4 years ago

minsikzzang commented 7 years ago

Issue

There are two places using invalid field types (map<string, unsigned int>) in https://github.com/facebook/facebook-ruby-ads-sdk/blob/master/lib/facebook_ads/ad_objects/ad.rb#L104 and https://github.com/facebook/facebook-ruby-ads-sdk/blob/master/lib/facebook_ads/ad_objects/ad_set.rb#L129

so it doesn't get found in https://github.com/facebook/facebook-ruby-ads-sdk/blob/master/lib/facebook_ads/field_types.rb#L44 when data for the field returned, and it returns as string

i.e.) so when it returns hash object { 'foo' => 'bar' }, it will be returned as "{\"foo\" => \"bar\" }" as a string

minsikzzang commented 6 years ago

This issue has been addressed in the PR https://github.com/facebook/facebook-ruby-ads-sdk/pull/33

stale[bot] commented 4 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.