search

facebook / facebook-ruby-business-sdk

Ruby SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
208 stars 161 forks source link

Ad leads causes infinite loop #61

Closed arr-dev closed 4 years ago

arr-dev commented 5 years ago

Calling FacebookAds::Ad.get(ad_id).leads.all when there are more than limit results causes infinite loop, since response doesn't include pagination data.

Only solution seems to be to place large enough limit, but that is not very safe, since API itself can limit the maximum number of results returned, which can again cause same infinite loop.

Using latest versions of gem and API, 0.3.2.5 and 3.2.

maxencehenneron commented 5 years ago

same issue with minimum_budgets 

FacebookAds::AdAccount.get(ad_account_id, 'name').minimum_budgets.all
stale[bot] commented 4 years ago

Hey there, it looks like there has been no activity on this issue recently. Has the issue been fixed, or does it still require the community's attention? This issue may be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 4 years ago

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please feel free to create a new issue with up-to-date information.