search

facebook / facebook-ruby-business-sdk

Ruby SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
208 stars 161 forks source link

Fixed bad reference for games_achieves #70

Closed mtam2 closed 5 years ago

mtam2 commented 5 years ago

In version 0.3.3.3, FacebookAds::User cannot be initialized because of this invalid syntax: The auto-generated code :games.achieves is invalid syntax. This change is to fix it to :games_achieves

facebook-github-bot commented 5 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 5 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

maxencehenneron commented 5 years ago

fixed in the latest version (0.3.3.4).

mtam2 commented 5 years ago

@maxencehenneron Could you please publish v0.3.3.4 to rubygems? It currently is still v0.3.3.3 https://rubygems.org/gems/facebookbusiness

techvineet commented 5 years ago

@maxencehenneron We want this fix to use this gem, please publish the latest version for rubygems.

jingping2015 commented 5 years ago

0.3.3.4 has been released.

mtam2 commented 5 years ago

Thank you!

maxencehenneron commented 5 years ago

@techvineet @mtam2 I'm not the owner of this repository. I just noticed it was fixed by looking at the source code