search

facebook / facebook-ruby-business-sdk

Ruby SDK for Meta Marketing API
https://developers.facebook.com/docs/business-sdk
Other
208 stars 161 forks source link

Add missing quotes around "file" fieldtype #81

Closed jamesr2323 closed 1 year ago

jamesr2323 commented 4 years ago

Two recently added fields for the AdAccount object had the fieldtype specified as file, instead of 'file', causing an error on first initializing the AdAccount, and many of the methods to function incorrectly. This PR adds the quotes, fixing the functionality.

facebook-github-bot commented 4 years ago

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

facebook-github-bot commented 4 years ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

alanho commented 1 year ago

@jamesr2323 thanks for the PR. this issue has been fixed internally at the upstream codegen process. so closing this