search

facebook / facebook-sdk-for-unity

The facebook sdk for unity.
https://developers.facebook.com/docs/unity
Other
489 stars 257 forks source link

Why are support dependencies added by AndroidSupportLibraryResolver.cs and not the Dependencies.xml? #291

Open JimmyDeemo opened 5 years ago

JimmyDeemo commented 5 years ago

When using the up to date play service resolver, https://github.com/googlesamples/unity-jar-resolver, there are support dependencies that are linked to the editor script AndroidSupportLibraryResolver withing the editor .dll.

This script adds the following dependencies;

AndroidSupportLibraryResolver.addSupportLibraryDependency(svcSupport, "support-v4", "25.3.1");
AndroidSupportLibraryResolver.addSupportLibraryDependency(svcSupport, "appcompat-v7", "25.3.1");
AndroidSupportLibraryResolver.addSupportLibraryDependency(svcSupport, "cardview-v7", "25.3.1");
AndroidSupportLibraryResolver.addSupportLibraryDependency(svcSupport, "customtabs", "25.3.1");

Now that the SDK has moved to using a Dependecies.xml file, can these be moved into there? This helps right now as I need to pin dependencies to avoid androidx compatability clashes.

troy-lamerton commented 5 years ago

Is there any progress on this?

apautrot commented 4 years ago

Can anyone from Facebook look at this please ?

gromilQaaaa commented 4 years ago

IDK if those old libs are still needed (I hope somebody just forgot to remove them), but looks like they are the problem of my project not building on android in Unity2019.3.7f1 with FacebookSDK 7.19.1. I use API 29:

Attribute application@appComponentFactory value=(android.support.v4.app.CoreComponentFactory) from [com.android.support:support-compat:28.0.0] AndroidManifest.xml:22:18-91 is also present at [androidx.core:core:1.1.0] AndroidManifest.xml:24:18-86 value=(androidx.core.app.CoreComponentFactory). Suggestion: add 'tools:replace="android:appComponentFactory"' to <application> element at AndroidManifest.xml:5:3-126 to override.

image

I guess this is the same problem: https://github.com/facebook/facebook-sdk-for-unity/issues/386