facebook / facebook-sdk-for-unity

The facebook sdk for unity.
https://developers.facebook.com/docs/unity
Other
491 stars 257 forks source link

App Id is 'baked into' manifest, but our App Id is dynamic #473

Open prodigga opened 4 years ago

prodigga commented 4 years ago

Checklist

Goals

I want to be able to specify multiple App's in the Facebook Settings file, and decide which one to use at runtime.

Expected Results

I can add Apps to my Facebook Settings without anything app-specific being 'compiled with' my game, since the app is yet to be determined.

Actual Results

The Android Manifest is modified with the App Id of the selected app index, though this might not be the app index we decide to use at runtime. We are concerned about problems this might cause, as the manifest has hardcoded app id values, ie:

<meta-data android:name="com.facebook.sdk.ApplicationId" android:value="fb{hardcoded value}" />

And our app might never initialise with this App Id.

Steps to Reproduce

App multiple apps, build the project. The App you intend to use may not be the one that is 'baked into' your manifest.

ovieira commented 6 months ago

This still happens in recent SDKs it seems?