search

facebook / fb303

fb303 is a core set of thrift functions that provide a common mechanism for querying stats and other information from a service.
Apache License 2.0
75 stars 48 forks source link

Add LibUnwind as a dependency of glog::glog (#128) #32

Closed Atry closed 7 months ago

Atry commented 2 years ago

Summary: X-link: https://github.com/facebookexperimental/eden/pull/128

X-link: https://github.com/facebookexperimental/rust-shed/pull/35

X-link: https://github.com/facebook/watchman/pull/1058

X-link: https://github.com/facebookincubator/reindeer/pull/5

X-link: https://github.com/facebook/sapling-staging/pull/8

X-link: https://github.com/facebookexperimental/edencommon/pull/5

X-link: https://github.com/facebookincubator/fizz/pull/82

X-link: https://github.com/facebookincubator/velox/pull/2487

X-link: https://github.com/facebookincubator/hsthrift/pull/101

X-link: https://github.com/facebookincubator/katran/pull/172

X-link: https://github.com/facebookincubator/mvfst/pull/273

X-link: https://github.com/fairinternal/AIRStore/pull/38

LibUnwind is a dependency of glog according to objdump. This diff adds ${LIBUNWIND_LIBRARY} to the CMake imported library glog::glog as an element in the IMPORTED_LINK_INTERFACE_LIBRARIES property.

Without this diff, there will be a linker error like this:

/usr/bin/ld: /usr/lib/x86_64-linux-gnu/libglog.so: undefined reference to symbol '_Ux86_64_getcontext'
//usr/lib/x86_64-linux-gnu/libunwind.so.8: error adding symbols: DSO missing from command line
collect2: error: ld returned 1 exit status

Differential Revision: D39340650

facebook-github-bot commented 2 years ago

This pull request was exported from Phabricator. Differential Revision: D39340650

facebook-github-bot commented 1 year ago

Hi @Atry!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 7 months ago

This pull request has been merged in facebook/fb303@b1388c2fc1c9e865e4058aedeb1d2e3c43f8ceb2.