search

facebook / fb303

fb303 is a core set of thrift functions that provide a common mechanism for querying stats and other information from a service.
Apache License 2.0
75 stars 46 forks source link

Doesn't configure when fbthrift isn't built with python #4

Closed yurivict closed 3 years ago

yurivict commented 4 years ago 
-- Configuring done
CMake Error at build/fbcode_builder/CMake/FBPythonBinary.cmake:494 (add_dependencies):
  The dependency target "FBThrift::thrift_py.py_lib" of target
  "fb303_thrift_py.py_sources_built" does not exist.
Call Stack (most recent call first):
  build/fbcode_builder/CMake/FBThriftPyLibrary.cmake:104 (add_fb_python_library)
  build/fbcode_builder/CMake/FBThriftLibrary.cmake:63 (add_fbthrift_py_library)
  fb303/thrift/CMakeLists.txt:15 (add_fbthrift_library)

Could you please add a cmake option to turn the python support on/off?

Thanks.

chadaustin commented 4 years ago

Hi @yurivict. Thanks for the report. This is low on our priority list, but it seems like a reasonable idea. If you have time to put together a patch, I'd support it.

In what environment are you trying to avoid the Python dependency?

yurivict commented 4 years ago

In what environment are you trying to avoid the Python dependency?

bfthrift is installed as a FreeBSD package, and fb303 needs to build based on it.

michel-slm commented 3 years ago

I'm packaging fb303 for Fedora now, and noticed the same issue. It's a trivial fix so I'll put up a patch for review internally soon.