facebook / fbjs

A collection of utility libraries used by other Meta JS projects.
MIT License
1.95k stars 313 forks source link

Consider extracting `shallowEqual`. #253

Open wtgtybhertgeghgtwtg opened 7 years ago

wtgtybhertgeghgtwtg commented 7 years ago

Or using a package that does shallow equal. Some packages (recompose, react-event-listener) end up requiring and using fbjs for the shallowEqual function, with the reasoning being that, since it's already required by react, it'd save some bits, which makes sense, but is advised against in the readme. This way, they can just use the shallow equal implementation fbjs uses instead of fbjs.