Open claudiopro opened 5 years ago
Ah, I totally missed that. Looks like it snuck in in #303. We should probably just fix that so it uses npm again. Or fallback to yarn. Or better, work out if you're using yarn in the caller. There's no reason for it to actually require yarn though.
That said, draft is using yarn for it's dependency manager so if you're working on draft, it should use yarn.
I don't particularly care to call it out for contributing in this project since we're fairly unfriendly to external contributions anyway (really not intended to be good at it). But we shouldn't break people trying to contribute to our projects.
fbjs
assumes in various placesyarn
is installed but doesn't declare it as a dependency or call it out in the README. To name a few:fbjs
prepublish script - https://github.com/facebook/fbjs/blob/af9fefad110a04821f71593b17263e8dece089cb/packages/fbjs/package.json#L11check-dependencies
Gulp plugin - https://github.com/facebook/fbjs/blob/ccad8f1e81daa851d18cc84153b5e1d595f1edef/packages/fbjs-scripts/gulp/check-dependencies.js#L25etc.
I believe it would be useful to call out
fbjs
depends on Facebook's omakase stack in the README at a minimum.