facebook / fbjs

A collection of utility libraries used by other Meta JS projects.
MIT License
1.95k stars 313 forks source link

fbjs assumes yarn is installed but doesn't declare it as dependency #344

Open claudiopro opened 5 years ago

claudiopro commented 5 years ago

fbjs assumes in various places yarn is installed but doesn't declare it as a dependency or call it out in the README. To name a few:

etc.

I believe it would be useful to call out fbjs depends on Facebook's omakase stack in the README at a minimum.

zpao commented 5 years ago

Ah, I totally missed that. Looks like it snuck in in #303. We should probably just fix that so it uses npm again. Or fallback to yarn. Or better, work out if you're using yarn in the caller. There's no reason for it to actually require yarn though.

That said, draft is using yarn for it's dependency manager so if you're working on draft, it should use yarn.

zpao commented 5 years ago

I don't particularly care to call it out for contributing in this project since we're fairly unfriendly to external contributions anyway (really not intended to be good at it). But we shouldn't break people trying to contribute to our projects.