search

facebook / fbjs

A collection of utility libraries used by other Meta JS projects.
MIT License
1.95k stars 313 forks source link

bump ua-parser-js from 0.7.30 to 1.0.35 #507

Closed cross19xx closed 1 year ago

cross19xx commented 1 year ago

Overview

This PR bumps ua-parser-js from 0.7.30 to 1.0.35, which contains, among a few fixes, a resolution for the Regular Expression Denial of Service (ReDoS) vulnerability.

facebook-github-bot commented 1 year ago

Hi @cross19xx!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 1 year ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

BaarishRain commented 1 year ago

Overview

This PR bumps ua-parser-js from 0.7.30 to 1.0.35, which contains, among a few fixes, a resolution for the Regular Expression Denial of Service (ReDoS) vulnerability.

Is there an ETA on when this will be merged?

bigfootjon commented 1 year ago

Thanks for the fix! Sorry about the delay in merging

cross19xx commented 1 year ago

Thanks for the fix! Sorry about the delay in merging

Thanks for the review and merge