jaymzh
commented
8 years ago This should be fixed, but in addition to latest updates here you'll need this: https://github.com/facebook/fbthrift/pull/135
Closed redrattus closed 8 years ago
jaymzh
commented
8 years ago This should be fixed, but in addition to latest updates here you'll need this: https://github.com/facebook/fbthrift/pull/135
[ 17%] Building CXX object CMakeFiles/fboss_agent.dir/fboss/agent/NeighborUpdater.cpp.o /home/junhosuh/workspace/fboss/fboss/agent/NeighborUpdater.cpp: In destructor ‘virtual facebook::fboss::NeighborUpdater::~NeighborUpdater()’: /home/junhosuh/workspace/fboss/fboss/agent/NeighborUpdater.cpp:156:37: error: no matching function for call to ‘std::vectorfolly::Future::push_back(std::remove_referencefolly::Future<void&>::type)’
stopTasks.push_back(std::move(f));
^
/home/junhosuh/workspace/fboss/fboss/agent/NeighborUpdater.cpp:156:37: note: candidates are:
In file included from /usr/include/c++/4.8/vector:64:0,
from /usr/include/c++/4.8/bits/random.h:34,
from /usr/include/c++/4.8/random:50,
from /usr/include/c++/4.8/bits/stl_algo.h:65,
from /usr/include/c++/4.8/algorithm:62,
from /usr/include/boost/container/detail/flat_tree.hpp:23,
from /usr/include/boost/container/flat_map.hpp:25,
from /home/junhosuh/workspace/fboss/fboss/agent/NeighborUpdater.h:12,
from /home/junhosuh/workspace/fboss/fboss/agent/NeighborUpdater.cpp:10:
/usr/include/c++/4.8/bits/stl_vector.h:901:7: note: void std::vector<_Tp, _Alloc>::push_back(const value_type&) [with _Tp = folly::Futurefolly::Unit; _Alloc = std::allocatorfolly::Future; std::vector<_Tp, _Alloc>::value_type = folly::Futurefolly::Unit]
push_back(const value_type& __x)
^
/usr/include/c++/4.8/bits/stl_vector.h:901:7: note: no known conversion for argument 1 from ‘std::remove_referencefolly::Future<void&>::type {aka folly::Future}’ to ‘const value_type& {aka const folly::Futurefolly::Unit&}’
/usr/include/c++/4.8/bits/stl_vector.h:919:7: note: void std::vector<_Tp, _Alloc>::push_back(std::vector<_Tp, _Alloc>::value_type&&) [with _Tp = folly::Futurefolly::Unit; _Alloc = std::allocatorfolly::Future; std::vector<_Tp, _Alloc>::value_type = folly::Futurefolly::Unit]
push_back(value_type&& __x)
^
/usr/include/c++/4.8/bits/stl_vector.h:919:7: note: no known conversion for argument 1 from ‘std::remove_referencefolly::Future<void&>::type {aka folly::Future}’ to ‘std::vectorfolly::Future::value_type&& {aka folly::Futurefolly::Unit&&}’
make[2]: * [CMakeFiles/fboss_agent.dir/fboss/agent/NeighborUpdater.cpp.o] Error 1
make[1]: * [CMakeFiles/fboss_agent.dir/all] Error 2
make: *\ [all] Error 2