janga800bic : added led_manager.json

[GoravGargCelestica]

Description

Added led_manager.json file to verify the data_corral_service and the data_corral_service_hw_test.

Motivation

Aim is to verify the data_corral_service and the data_corral_service_hw_test.

Testing

1. jq command output is clean.

2. Data Corral Service Logs : j3_data_corral_service_logs.txt

3. Data Corral Service HW Test Logs : j3_data_corral_service_hw_test_logs.txt

[facebook-github-bot]

Hi @GoravGargCelestica!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

[facebook-github-bot]

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[kimdo8736]

Hi, please remove the following

"chassisEepromName" : "CHASSIS" , "fruEepromList" : { "CHASSIS" : { "path" : "/run/devmap/eeproms/COME_EEPROM" } },

This is weutil.json contents. Please apply the same fixes for tahan and montblanc. Thanks.

[GoravGargCelestica]

Hi, please remove the following

"chassisEepromName" : "CHASSIS" , "fruEepromList" : { "CHASSIS" : { "path" : "/run/devmap/eeproms/COME_EEPROM" } },

This is weutil.json contents. Please apply the same fixes for tahan and montblanc. Thanks.

Hi @kimdo8736

Thankyou for your feedback. We have added this EEPROM content intentionally to avoid failures while running the data_corral_service_hw_test suite. Without this, test suite has the following error:

C++ exception with description "std::runtime_error: Invalid EEPROM name CHASSIS. Valid EEPROM names are: " thrown in the test body.

Complete Log: fail_data_corral_service_hw_test_log.txt

After adding it the test suite is passed successfully : pass_data_corral_service_hw_test_log.txt

Please let me know your comment.

[kimdo8736]

Thanks for the response, with this commit (https://github.com/facebook/fboss/commit/dff361d29b7ae85f966aaf0a7cfa263a9a1d340e)

You can now run without the EEPROM contents. Please let me know how that goes on your end. Thanks.

[facebook-github-bot]

@GoravGargCelestica has updated the pull request. You must reimport the pull request before landing.

[GoravGargCelestica]

Thanks for the response, with this commit (dff361d)

You can now run without the EEPROM contents. Please let me know how that goes on your end. Thanks.

Hi @kimdo8736 ,

Thanks for your feedback. Yes, with the recent commit (dff361d) there is no need to have the EEPROM content in the led_manager.json , I have updated the changes. Also, attached the latest testing result in the PR description, please help to review again.

I have updated Tahan and Montblanc PRs too.

Thanks, Gorav.

[facebook-github-bot]

@GoravGargCelestica has updated the pull request. You must reimport the pull request before landing.

[facebook-github-bot]

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

[facebook-github-bot]

@mikechoifb merged this pull request in facebook/fboss@d8c08a944d3a5fb2b76a808df698943e72c8d81c.