facebook / fboss

Facebook Open Switching System Software for controlling network switches.
Other
866 stars 301 forks source link

tahan: config: add tahan dvt qsfp config file #223

Closed zhongedward closed 1 month ago

zhongedward commented 2 months ago

Description This PR is for janga dvt qsfp config file.

Motivation 1.This is new added qsfp config file in tahan dvt machine(note: this file is approved from https://github.com/facebookexternal/fboss.bsp.celestica/blob/master/tahan/osfp/qsfp.conf) i just copy it here and then raise it again. 2.Test cmd:

Test cmd: ./bin/run_test.py qsfp --qsfp-config qsfp.conf --filter_file=./share/hw_sanity_tests/bsp_sanity_tests.conf

Test Plan 1.The correctness of the format has been verified on this website https://jsonlint.com/ 2.This PR has used "jq" cmd to pretty the format. 3.The lint issue is not about the json file. image

4.Test log as follow:

image

hwtest_results_2022_Aug_28-10_37_25_AM.csv tahan_oss_test_log_12.18.txt

facebook-github-bot commented 2 months ago

Hi @zhongedward!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

clslucas commented 2 months ago

signed individual license.

facebook-github-bot commented 2 months ago

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 1 month ago

@zhongedward has updated the pull request. You must reimport the pull request before landing.

facebook-github-bot commented 1 month ago

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

karthik-gengan commented 1 month ago

@mikechoifb Thanks for your guidance. We will update in BSP GITHUB. The Shanghai team will be on a National Day Holiday from Sept 30th to Oct 7th. We will close this PR after they return.