facebook / fboss

Facebook Open Switching System Software for controlling network switches.
Other
860 stars 295 forks source link

montblanc:config: update fan service config #225

Closed QiuyunXie closed 2 weeks ago

QiuyunXie commented 2 weeks ago

Motivation

  1. Update Montblanc fan service config for temp sensor overheat safety case. For inlet temp sensor, add entries to the linear table to cover the temp sensor overheat safety case. For those sensors calculate PWM with PID algorithm, as aligned with Meta thermal, the PID algorithm already have appropriate overheat safety. We can ignore additional sensor overheat safety for those sensors.
  2. Add fan watchdog in fanservice config.

Test plan

  1. For temp sensor overheat safety case, thermal team has tested it, the test result is as expected.
  2. For fan watchdog, Firstly, run fan service, check the fan speed; Then stop fan service, when the fan service is stopped for more than 30 seconds, check the fan speed changes. (For testing purposes, the fan watchdog timeout is temporarily set to 30 seconds). Fan speed log is as below. From the log, after fan service was stopped for more than 30 seconds, the FAN PWM changed to 24. It's as expected. [root@localhost hwmon3]# date +"%T"; cat ./pwm1; cat ./pwm2; cat ./pwm3; cat ./pwm4; cat ./pwm5; cat ./pwm6; cat ./pwm7; cat ./pwm8; cat ./fan_input 16:21:07 20 20 20 20 20 20 20 20 7200 7650 7200 7650 7350 7650 7200 7650 7200 7500 7200 7650 7200 7500 7200 7500 [root@localhost hwmon3]# date +"%T"; cat ./pwm1; cat ./pwm2; cat ./pwm3; cat ./pwm4; cat ./pwm5; cat ./pwm6; cat ./pwm7; cat ./pwm8; cat ./fan_input 16:21:29 20 20 20 20 20 20 20 20 7200 7650 7200 7500 7200 7650 7200 7650 7200 7500 7200 7650 7050 7650 7200 7650 [root@localhost hwmon3]# date +"%T"; cat ./pwm1; cat ./pwm2; cat ./pwm3; cat ./pwm4; cat ./pwm5; cat ./pwm6; cat ./pwm7; cat ./pwm8; cat ./fan_input 16:21:34 20 20 20 20 20 20 20 20 7200 7650 7200 7650 7200 7500 7200 7650 7200 7650 7200 7650 7200 7500 7200 7650 [root@localhost hwmon3]# date +"%T"; cat ./pwm1; cat ./pwm2; cat ./pwm3; cat ./pwm4; cat ./pwm5; cat ./pwm6; cat ./pwm7; cat ./pwm8; cat ./fan_input 16:21:37 24 24 24 24 24 24 24 24 7800 8400 7650 8400 7800 8400 7650 8250 7650 8250 7650 8250 7650 8250 7650 8400 [root@localhost hwmon3]# date +"%T"; cat ./pwm1; cat ./pwm2; cat ./pwm3; cat ./pwm4; cat ./pwm5; cat ./pwm6; cat ./pwm7; cat ./pwm8; cat ./fan*_input 16:21:42 24 24 24 24 24 24 24 24 8400 9000 8400 9000 8400 9000 8400 9000 8400 9000 8250 9000 8400 9000 8250 9000
facebook-github-bot commented 2 weeks ago

Hi @QiuyunXie!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

facebook-github-bot commented 2 weeks ago

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

facebook-github-bot commented 2 weeks ago

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 weeks ago

@mikechoifb merged this pull request in facebook/fboss@01b043ca484cf56aaf23762d765a046afd12446e.