facebook / fboss

Facebook Open Switching System Software for controlling network switches.
Other
860 stars 295 forks source link

tahan800bc : added RUNBMC & COME_FRU EEPROMs entry in the weutil.json file. #228

Closed GoravGargCelestica closed 2 weeks ago

GoravGargCelestica commented 2 weeks ago

Description

Tahan platform has the following EEPROMs available:

[root@localhost 211_47]# ls /run/devmap/eeproms/
COME_EEPROM  COME_FRU  RUNBMC_EEPROM  SMB_EEPROM
[root@localhost 211_47]#

Entry for the EEPROMs RUNBMC & COME_FRU is missing in the weutil.json file, PR is raised to add this entry.

Also, cleaned up the weutil.json file for the following: In weutil FBOSS service, the default implicit values of idEepromFormatVer is v4 and for offset it is 0. Hence passing the same values in the configuration is redundant.

https://github.com/facebook/fboss/blob/a374fbf363af163950e3c4e851723f62ec8daf90/fboss/platform/weutil/if/weutil_config.thrift#L18-L26

Motivation

Aim is to have all the proper EEPROMs entries available in the weutil.json file to be tested by weutil FBOSS service.

Testing

tahan800bc_weutil_logs.txt

facebook-github-bot commented 2 weeks ago

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot commented 2 weeks ago

@mikechoifb merged this pull request in facebook/fboss@d8b62809c48356faad55a51827bd88ee2ad5ddc7.