facebook / fboss

Facebook Open Switching System Software for controlling network switches.
Other
860 stars 295 forks source link

montblanc: config: Update sensor configuration for compatibility with 2nd source #238

Open clslucas opened 4 days ago

clslucas commented 4 days ago

Description Updated the sensors service config to support 2nd source in fboss with latest source code with the latest platform manager config file: https://github.com/facebook/fboss/pull/216

There lint issue with below detial info: image

Motivation Added 2nd source config with two interchangeable chips based on the field "versionedSensors". image Montblanc sensor config lists: https://docs.google.com/spreadsheets/d/1V_JFLw2m0Zu1DUgVeVPKSGsQrPkRYgCh/edit?gid=1703809973#gid=1703809973

Removed the V2 folder to ensure compatibility with the second source using a single configuration file.

Test Plan

Current tested the new config file on two tpye board normal. montblanc_sensor_config_MP_test_log_20240924.txt montblanc_sensor_config_IFX_test_log_20240924.txt

clslucas commented 3 days ago

@kimdo8736 please check the new commit, thanks

kimdo8736 commented 2 days ago

Otherwise, other sensor changes look good to me.

Thank you for the changes Lucas and detailed test plans!

facebook-github-bot commented 1 day ago

@mikechoifb has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.